Project

General

Profile

Activity

From October 02, 2014 to October 31, 2014

October 31, 2014

23:45 Bug #466: Qt: Translations are not applied
William Pitcock wrote:
> Best to leave it to jlindgren then, the current approach is the same as libaudgui basically...
John Lindgren

October 30, 2014

22:58 Bug #466: Qt: Translations are not applied
Qt itself can be translated by installing a custom translator which is subclassed from QTranslator. I'll work on tha... Ariadne Conill

October 29, 2014

04:40 Bug #473: jack-ng does not compile with Clang
Interestingly enough, the code would have compiled with -std=c++14.
John Lindgren
03:58 Bug #473 (Closed): jack-ng does not compile with Clang
John Lindgren
03:00 Bug #474: libaudqt: Clean up properly on shutdown
Fixed the crash:
https://github.com/audacious-media-player/audacious/commit/024075f987ed20aa9f34c4a19100202fef9765e9
...
John Lindgren
00:10 Bug #474 (Closed): libaudqt: Clean up properly on shutdown
Audacious segfaults on shutdown if the "Song Info" dialog was opened before.
Version:
latest from git
Steps to...
Thomas Lange
02:17 Bug #466: Qt: Translations are not applied
Best to leave it to jlindgren then, the current approach is the same as libaudgui basically. Ariadne Conill
02:09 Bug #466: Qt: Translations are not applied
It is the same as before, still not translated. Thomas Lange
02:02 Bug #466: Qt: Translations are not applied
Please try latest libaudqt, it should have an appropriate fix. Ariadne Conill
02:00 Bug #466: Qt: Translations are not applied
Done, sorry for the inconvenience.
What is the proper fix though?
Thomas Lange
01:46 Bug #466: Qt: Translations are not applied
That fix is incorrect. Please revert. Ariadne Conill
01:37 Bug #466: Qt: Translations are not applied
At first it still used the English strings, but the fix was trivial.
Using _() instead of N_() resolved it.
Thomas Lange
00:40 Bug #466: Qt: Translations are not applied
Qt designer vestiges have been nuked. The menus should now be translated. Ariadne Conill

October 28, 2014

23:25 Bug #473 (Closed): jack-ng does not compile with Clang
With Clang 3.5.0 on Arch Linux this error occurs when building _jack-ng_:... Thomas Lange

October 27, 2014

01:05 Bug #466 (In Progress): Qt: Translations are not applied
Thanks John, good work.
I just fixed some remaining issues.
TODO:
- menu bar
- dialog buttons
- combobox "Pref...
Thomas Lange

October 26, 2014

17:17 Bug #469 (Closed): Qt: Accelerators are not translated correctly
I committed a patch that uses QString::replace(). QString is what we eventually need anyway, so there's no reason to... John Lindgren
17:13 Bug #466: Qt: Translations are not applied
I fixed several issues in the PreferencesWidget code; all of the settings dialog should be translated now. John Lindgren
16:37 Bug #472 (Rejected): VBR seeking problems in relation to LAME/Xing header (libmpg123?)
I can confirm the problem. Thank you for the good analysis and the test files. Please forward this report to the mp... John Lindgren
13:05 Bug #472: VBR seeking problems in relation to LAME/Xing header (libmpg123?)
Just tested both files with Audacious 3.5.2, problem still exists (Arch). As does it in the 3.2.4 version (Debian-Whe... Maarten van Eeuwijk

October 24, 2014

22:52 Bug #472: VBR seeking problems in relation to LAME/Xing header (libmpg123?)
Please upload an example file. John Lindgren
01:25 Bug #472 (Rejected): VBR seeking problems in relation to LAME/Xing header (libmpg123?)
I have had some problems with Audacious and VBR files for some time now, so I decided to take a look into it.

The...
Maarten van Eeuwijk

October 22, 2014

23:57 Bug #471 (Rejected): Dekstop Notification
Audacious doesn't know and doesn't care whether you click on the network icon in the panel. Furthermore Audacious do... John Lindgren
18:12 Bug #471 (Rejected): Dekstop Notification
Every now and then I would have to click on something to cause the desktop notification to disappear.
By anything I ...
Audy Murphy

October 18, 2014

18:31 Feature #429: Please enable scrobbling to libre.fm in Scrobbler 2.0
Forgot to add the link... http://bugs.foocorp.net/projects/librefm/wiki/Clientsaudacious Franko Burolo
18:31 Feature #429: Please enable scrobbling to libre.fm in Scrobbler 2.0
There seems to already exist a patch for this, but I don't know how to compile it. Is it of any use? Could it be inte... Franko Burolo
17:35 Bug #469: Qt: Accelerators are not translated correctly
Updated patch attached. Thomas Lange
16:33 Bug #469: Qt: Accelerators are not translated correctly
The translations are already UTF-8, so str_to_utf8() is unnecessary. You can use str directly if you want, there's n... John Lindgren
15:34 Bug #469: Qt: Accelerators are not translated correctly
OK, please take a look on the attached patch.
Two questions:
Is _str_copy()_ the right function to use here or sh...
Thomas Lange
05:59 Bug #469: Qt: Accelerators are not translated correctly
William Pitcock wrote:
> My concern with str_replace_char() is multibyte safety, i.e. CJK translations. If you want...
John Lindgren
06:03 Bug #215: Audacious shows bad length for some mp3s.
The fix for #441 should improve the situation in 3.6. John Lindgren

October 17, 2014

23:52 Bug #215: Audacious shows bad length for some mp3s.
The problem still exists: Downloaded file in comment #3 and another mp3-file from the internet.
*Version*
Audacio...
Bernhard Schülke
23:34 Bug #469: Qt: Accelerators are not translated correctly
John, what do you think about this?
Can _str_replace_char()_ be used for these translations?
If not, we can use o...
Thomas Lange
21:47 Bug #469: Qt: Accelerators are not translated correctly
My concern with str_replace_char() is multibyte safety, i.e. CJK translations. If you want to change the behaviour t... Ariadne Conill
22:57 Bug #468 (Closed): [Patch] Qt: Support left mouse button in time slider
https://github.com/audacious-media-player/audacious-plugins/commit/6ef279350d494c71c1986a986825d850d6359f53 Thomas Lange
22:39 Bug #468: [Patch] Qt: Support left mouse button in time slider
On Linux the left mouse button has no effect on the slider.
If you want to change its position you have to use the s...
Thomas Lange
21:45 Bug #468: [Patch] Qt: Support left mouse button in time slider
I tested the patch on Mac and it causes no regressions there, but I don't understand what the goal of the patch is, i... Ariadne Conill
21:39 Bug #468: [Patch] Qt: Support left mouse button in time slider
Can you explain the problem here? Doesn't the time slider already work with left mouse button? Ariadne Conill
21:44 Bug #466: Qt: Translations are not applied
I am planning to remove the last bits of the Qt Designer stuff this weekend. Ariadne Conill

October 15, 2014

15:33 Feature #238 (Closed): Add 'Album Artist' support
John Lindgren
14:31 Feature #470 (Rejected): Improved Music Organiser
Duplicate of #238. John Lindgren
12:46 Feature #470 (Rejected): Improved Music Organiser
From My perspective Audacious is a powerful and simple player.
But its Music organising is lacking. No Album Artist ...
Rijnhard Hessel

October 14, 2014

17:20 Bug #469: Qt: Accelerators are not translated correctly
I think that's fine.
All translated strings should contain only one accelerators already.
And I doubt that translat...
Thomas Lange
17:00 Bug #469: Qt: Accelerators are not translated correctly
How about using str_replace_char()? John Lindgren
16:27 Bug #469 (Closed): Qt: Accelerators are not translated correctly
translate_str() in libaudqt/util.cc
assumes the accelerator is always the prefix of a single word.
This is not alwa...
Thomas Lange
17:04 Bug #468: [Patch] Qt: Support left mouse button in time slider
Thanks, I will commit it if William confirms that it works on Mac OS. Thomas Lange
16:58 Bug #468: [Patch] Qt: Support left mouse button in time slider
Looks good. John Lindgren
16:15 Bug #468 (Closed): [Patch] Qt: Support left mouse button in time slider
The attached patch adds the support for using
the left mouse button in the time slider.
Please review.
Thomas Lange
16:58 Bug #467 (Closed): [Patch] Qt: Border around labels in status bar
https://github.com/audacious-media-player/audacious-plugins/commit/0924855c50b2e232bfa77837ca78163ac1f5d31a Thomas Lange
16:48 Bug #467: [Patch] Qt: Border around labels in status bar
Looks good to me. John Lindgren
16:05 Bug #467 (Closed): [Patch] Qt: Border around labels in status bar
On Linux the status bar of the Qt interface shows borders
around the labels (see the attached screenshot).
The at...
Thomas Lange
16:47 Bug #466: Qt: Translations are not applied
I don't think this should be a blocker for 3.6 since the Qt UI is only going to be a technical preview in that releas... John Lindgren
15:58 Bug #466 (Closed): Qt: Translations are not applied
Almost all strings are shown in English with the Qt interface.
Only some window titles and buttons use the transla...
Thomas Lange

October 05, 2014

07:31 Feature #368 (Rejected): Add an option to display playlists tabs in multiple rows
Closing since #160 is now implemented; you will be able to dock the playlist manager along the side of the interface ... John Lindgren
07:30 Feature #160 (Closed): Playlist tabs in a vertical column
John Lindgren wrote:
> We could make the playlist manager a dockable plugin.
Implemented in Git master.
John Lindgren
04:48 Feature #465 (Rejected): addition of song by dragging folder to audacious
Given that the Qt UI hasn't been released yet, even in alpha, I don't think we need tickets opened for missing featur... John Lindgren
04:46 Feature #443 (Closed): Cache for URL
John Lindgren
04:24 Feature #213 (Closed): Crossfade plugin doesn't work on manual song change
I've implemented the following changes for 3.6:
- Added an option to crossfade on seek or manual song change, with a...
John Lindgren

October 04, 2014

13:19 Feature #465: addition of song by dragging folder to audacious
He may be discussing the Qt port, where this is not yet implemented. Ariadne Conill

October 03, 2014

21:10 Feature #465: addition of song by dragging folder to audacious
That works already for a long time. Here I mostly run Fedora with GNOME. Dragging a folder from its default file mana... Michael Schwendt
19:42 Feature #465 (Rejected): addition of song by dragging folder to audacious
try to add feature whenever we drag folder to audacious song from that folder get added to library. we would not have... sahil guleri
 

Also available in: Atom