Project

General

Profile

Feature #1184

Merge recent 08/31 Qt Song Info Edit window commits into GTK vsn. (patch included)

Added by Jim Turner over 1 year ago. Updated over 1 year ago.

Status:
Rejected
Priority:
Minor
Assignee:
-
Category:
-
Target version:
-
Start date:
September 07, 2022
Due date:
% Done:

0%

Estimated time:
Affects version:
4.2.1

Description

This patch should apply 08/31 commits (ddcbce7 & 7022315) into the GTK version ("Adjust widget stretch as suggested by Thomas Lange" and "Use QTextEdit for the Song Info path. Closes: #1174") and make the GTK window work much more like the Qt version. Even though the GTK vsn. already allows selecting the entry-path text, this version also makes this into a scrollable box (like Qt).

infowin.cc (17.4 KB) infowin.cc Jim Turner, September 07, 2022 05:21
infowin.cc.diff (5.56 KB) infowin.cc.diff Jim Turner, September 07, 2022 05:21

History

#1 Updated by John Lindgren over 1 year ago

  • Status changed from New to Rejected

I don't think we want this. The scrollable box in the Qt version is just a consequence of using QTextEdit, and not necessarily better than the GTK behavior of expanding the dialog vertically.

Also, the GTK interface is deprecated and uses a toolkit that is two major versions behind what GNOME is on now. Not sure about other distributions, but Arch Linux isn't even packaging it any more. We'll continue to fix any bugs found in it, but trying to update it to match the Qt interface probably isn't worthwhile at this point.

Also available in: Atom PDF