Project

General

Profile

Bug #1030

Album cover image does not display from ID3v2.2 tag

Added by Paul Richter over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
libaudtag
Target version:
4.1
Start date:
October 12, 2020
Due date:
% Done:

100%

Estimated time:
Affects version:
4.0.4

Description

The iTunNORM and iTunSMPB tags are added by iTunes, and both are very long strings of digits. If both of these are present and excessively long strings (they show up in red in Kid3), audacious does not display the album artwork. The image is visible if either value is deleted or set to a short string.

13 Don_t Miss You At All.mp3 (4.71 MB) 13 Don_t Miss You At All.mp3 Paul Richter, October 20, 2020 12:02
id3-common.cc.diff (927 Bytes) id3-common.cc.diff Jim Turner, October 21, 2020 04:47
id3-common.h.diff (558 Bytes) id3-common.h.diff Jim Turner, October 21, 2020 04:47
id3v22.cc.diff (622 Bytes) id3v22.cc.diff Jim Turner, October 21, 2020 04:47
id3v24.cc.diff (623 Bytes) id3v24.cc.diff Jim Turner, October 21, 2020 04:47

History

#1 Updated by Jim Turner over 3 years ago

Can you attach a file that's got both these tags (that doesn't work)?

Thanks,

Jim

#2 Updated by Paul Richter over 3 years ago

Sample mp3 file. It seems that the problem gets fixed (the image displays) if any of the tags get changed and saved to the file.

#3 Updated by Jim Turner over 3 years ago

Thanks for the example!

It appears that iTunes is saving the tags as id3v2.2 instead of the more modern id3v2.4, and apparently there's a slight difference in the format for embedding images between the two (v2.2's "PIC" tag vs. v2.4's "APIC" tag) See the specs here: v2.2: https://id3.org/id3v2-00 and v2.4: https://id3.org/id3v2.4.0-frames, or else iTunes is just screwing with us (see here!: https://www.joelverhagen.com/blog/2010/12/how-itunes-uses-id3-tags)

Anyway, I patched Audacious (see attached files from src/libaudtag/id3), and it seems to work now, at least for your example. Please try out if you can rebuild Audacious, and see if it works for all your cases & post back here (as I don't have any other music files with the old id3v2.2 tags to test or software to tag 'em that way)!

I'm not a developer on the Audacious team, but I've done alot of work on the Album art plugin and other stuff in my Audacious fork (send me an email to my redmine profile email if you're interested in that - I won't discuss here on THEIR bug system), so I can't merge the patch to mainline Audacious, but I took an interest in testing / fixing this bug. Perhaps if it can be further tested, I can submit the patch as a pull request though.

Regards,

Jim

#4 Updated by Jim Turner over 3 years ago

One other thing - I suspect that when you edit your tags, your tag-editing software may be silently converting them to id3v2.4 for you, which will cause the image tag (now "APIC" format) to work properly.

#5 Updated by Paul Richter over 3 years ago

I rebuilt with the patches and they fixed the problem. Thanks a lot.

#6 Updated by John Lindgren over 3 years ago

Thank you both for looking into this. The ID3v2.2 code is somewhat unloved so I don't doubt it's a mistake in our code. I'll see about merging in a fix based on Jim's patches.

#7 Updated by John Lindgren over 3 years ago

  • Category set to libaudtag
  • Subject changed from Album cover image does not display if file contains iTunNORM and iTunSMPB tags to Album cover image does not display from ID3v2.2 tag

#9 Updated by Thomas Lange over 3 years ago

  • Target version set to 4.1

Also available in: Atom PDF