Project

General

Profile

Feature #428

Lyrics plugin should lowercase all-capital artist names before calling LyricsWiki API

Added by Richard Harris about 11 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Minor
Assignee:
-
Category:
plugins/lyricwiki
Target version:
-
Start date:
March 11, 2013
Due date:
% Done:

0%

Estimated time:
Affects version:

Description

When searching for songs via the LyricsWiki API, artist names are case-insensitive except when one or more of the words in the artist name are all-capitals. For example, these queries match the page 'Dir en Grey:Diabolos':

http://lyrics.wikia.com/api.php?action=lyrics&artist=dir+en+grey&song=diabolos&fmt=xml
http://lyrics.wikia.com/api.php?action=lyrics&artist=Dir+en+grey&song=diabolos&fmt=xml
http://lyrics.wikia.com/api.php?action=lyrics&artist=Dir+en+Grey&song=diabolos&fmt=xml

But these fail to return a result:

http://lyrics.wikia.com/api.php?action=lyrics&artist=Dir+en+GREY&song=diabolos&fmt=xml
http://lyrics.wikia.com/api.php?action=lyrics&artist=DIR+EN+GREY&song=diabolos&fmt=xml

The simple fix is, upon failure, to re-attempt the query with a lower-cased artist, which should always work.

Related to #268 as the retry mechanism is identical.

A song such as DIR EN GREY - DIABOLOS will fail a lyrics lookup because of the way MediaWiki works - it is case-insensitive except for song titles in all capitals.

History

#1 Updated by John Lindgren about 11 years ago

Why would an artist name ever be in all caps? In general, I'm against adding "on the fly" corrections for bad tags in Audacious. The tags should be corrected by a tag editor instead.

#2 Updated by Richard Harris about 11 years ago

Why? Because that's how the artist chose to style the ID3 tags. I didn't post this for speculation, it actually affected me.

I don't think this is a correction of bad tags, more a workaround for limitations in the LyricsWiki API, which is supposed to be case-insensitive.

#3 Updated by John Lindgren about 11 years ago

Richard Harris wrote:

Why? Because that's how the artist chose to style the ID3 tags. I didn't post this for speculation, it actually affected me.

My response was not speculation either. I suggested a concrete solution of using a tag editor to fix the ID3 tags.

I don't think this is a correction of bad tags, more a workaround for limitations in the LyricsWiki API, which is supposed to be case-insensitive.

If this a defect in the LyricWiki API, then you should report it to the LyricWiki team so they can implement a real fix, instead of asking for a workaround in Audacious.

#4 Updated by Richard Harris over 10 years ago

Resolved at the LyricWiki side.

#5 Updated by John Lindgren over 10 years ago

  • Status changed from New to Rejected

All right, closing.

Also available in: Atom PDF